Airblader commented on a change in pull request #17186: URL: https://github.com/apache/flink/pull/17186#discussion_r704249815
########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/converters/JsonObjectConverter.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.expressions.converter.converters; + +import org.apache.flink.table.api.JsonOnNull; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.expressions.CallExpression; +import org.apache.flink.table.expressions.Expression; +import org.apache.flink.table.expressions.ValueLiteralExpression; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule; +import org.apache.flink.table.planner.functions.sql.FlinkSqlOperatorTable; + +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.SqlJsonConstructorNullClause; + +import java.util.LinkedList; +import java.util.List; + +/** Conversion for {@link BuiltInFunctionDefinitions#JSON_OBJECT}. */ +class JsonObjectConverter extends CustomizedConverter { + @Override + public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) { + checkArgument(call, (call.getChildren().size() - 1) % 2 == 0); + final List<RexNode> operands = new LinkedList<>(); + + final SqlJsonConstructorNullClause onNull = + ((ValueLiteralExpression) call.getChildren().get(0)) + .getValueAs(JsonOnNull.class) + .map(this::convertOnNull) + .orElseThrow(() -> new TableException("Missing argument for ON NULL.")); + operands.add(context.getRelBuilder().getRexBuilder().makeFlag(onNull)); Review comment: Yes, there is a Calcite bug here which was resolved in https://issues.apache.org/jira/browse/CALCITE-4394 (Calcite 1.27). Basically Calcite didn't take into account the leading OnNull argument during type inference, causing values to be inferred as strings, so `VALUE NULL` would work even without a cast. I guess we'll need to add our own definition here instead, and take this into the Calcite 1.27 upgrade to be removed again. ########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/converters/JsonObjectConverter.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.expressions.converter.converters; + +import org.apache.flink.table.api.JsonOnNull; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.expressions.CallExpression; +import org.apache.flink.table.expressions.Expression; +import org.apache.flink.table.expressions.ValueLiteralExpression; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule; +import org.apache.flink.table.planner.functions.sql.FlinkSqlOperatorTable; + +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.SqlJsonConstructorNullClause; + +import java.util.LinkedList; +import java.util.List; + +/** Conversion for {@link BuiltInFunctionDefinitions#JSON_OBJECT}. */ +class JsonObjectConverter extends CustomizedConverter { + @Override + public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) { + checkArgument(call, (call.getChildren().size() - 1) % 2 == 0); + final List<RexNode> operands = new LinkedList<>(); + + final SqlJsonConstructorNullClause onNull = + ((ValueLiteralExpression) call.getChildren().get(0)) + .getValueAs(JsonOnNull.class) + .map(this::convertOnNull) + .orElseThrow(() -> new TableException("Missing argument for ON NULL.")); + operands.add(context.getRelBuilder().getRexBuilder().makeFlag(onNull)); Review comment: ~I actually think this is the incorrect order of arguments, and it hilariously hides an issue.~ Could also be a Calcite bug, though. Investigating. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
