dawidwys commented on a change in pull request #17135:
URL: https://github.com/apache/flink/pull/17135#discussion_r704346332



##########
File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md
##########
@@ -211,4 +223,41 @@ Flink currently only provides processing guarantees for 
jobs without iterations.
 
 Please note that records in flight in the loop edges (and the state changes 
associated with them) will be lost during failure.
 
+## Checkpointing with parts of the graph finished *(BETA)*
+
+Starting from Flink 1.14 it is possible to continue performing checkpoints 
even if parts of the job graph have finished processing all data, because it 
was a bounded source. The feature must be enabled

Review comment:
       First of all, I agree, this sentence is not very clear. I would not use 
`all` / `only`, because this way the reader might be confused that it works iff 
the job graph contains exclusively bounded sources.
   
   I will rephrase it to: 
   > Starting from Flink 1.14 it is possible to continue performing checkpoints 
even if parts of the job
   graph have finished processing all data, which might happen if it contains 
bounded sources. The
   WDYT?

##########
File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md
##########
@@ -211,4 +223,41 @@ Flink currently only provides processing guarantees for 
jobs without iterations.
 
 Please note that records in flight in the loop edges (and the state changes 
associated with them) will be lost during failure.
 
+## Checkpointing with parts of the graph finished *(BETA)*
+
+Starting from Flink 1.14 it is possible to continue performing checkpoints 
even if parts of the job graph have finished processing all data, because it 
was a bounded source. The feature must be enabled

Review comment:
       First of all, I agree, this sentence is not very clear. I would not use 
`all` / `only`, because this way the reader might be confused that it works iff 
the job graph contains exclusively bounded sources.
   
   I will rephrase it to: 
   > Starting from Flink 1.14 it is possible to continue performing checkpoints 
even if parts of the job
   graph have finished processing all data, which might happen if it contains 
bounded sources. The...
   
   WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to