curcur commented on pull request #17120:
URL: https://github.com/apache/flink/pull/17120#issuecomment-915194368
Hey @dawidwys , I am fine with either way. The only concern is as mentioned
above, the code has an implicit assumption that `currentTransactionHolder !=
null`
in TwoPhaseCommitSinkFunction#snapshotState
```
checkState(
currentTransactionHolder != null,
"bug: no transaction object when performing state snapshot");
```
I am not sure whether this has implicit effects.
- For invalid timestamp: since the `TransactionHolder#empty` refers to
no-transaction, I think timestamp does not matter that much?
- I agree we should not serialize the transaction start time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
