AHeise commented on a change in pull request #16940:
URL: https://github.com/apache/flink/pull/16940#discussion_r704437448
##########
File path:
flink-test-utils-parent/flink-connector-testing/src/test/java/org/apache/flink/connectors/test/common/utils/TestDataMatchersTest.java
##########
@@ -140,7 +175,22 @@ public void testOutOfOrder() throws Exception {
final List<String> result = unionLists(splitA, splitB, reverted);
final TestDataMatchers.MultipleSplitDataMatcher<String> matcher =
TestDataMatchers.matchesMultipleSplitTestData(testDataCollection);
- assertMatcherFailedWithDescription(result.iterator(), matcher,
"Unexpected record '3'");
+ String expectedDescription =
+ "Unexpected record '3' at position 6\n"
+ + "Current progress of multiple split test data
validation:\n"
+ + "Split 0 (3/3): \n"
+ + "alpha\n"
+ + "beta\n"
+ + "gamma\n"
+ + "Split 1 (3/3): \n"
+ + "one\n"
+ + "two\n"
+ + "three\n"
+ + "Split 2 (0/3): \n"
+ + "1\t<----\n"
+ + "2\n"
+ + "3\n";
+ assertMatcherFailedWithDescription(result.iterator(), matcher,
expectedDescription);
Review comment:
Here it would be nice to also see the actual elements and not just the
expected. For example, did we just receive incorrect output or was it swapped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
