Github user subhankarb commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r67904127
  
    --- Diff: 
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfig.java
 ---
    @@ -0,0 +1,237 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.redis.common.config;
    +
    +import com.google.common.base.Preconditions;
    +
    +import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
    +import redis.clients.jedis.HostAndPort;
    +import redis.clients.jedis.Protocol;
    +
    +import java.io.Serializable;
    +import java.net.InetSocketAddress;
    +import java.util.HashSet;
    +import java.util.Set;
    +
    +/**
    + * Configuration for Jedis Cluster.
    + */
    +public class JedisClusterConfig implements Serializable {
    +   private static final long serialVersionUID = 1L;
    +
    +   private Set<InetSocketAddress> nodes;
    +   private int timeout;
    +   private int maxRedirections;
    +   private int maxTotal;
    +   private int maxIdle;
    +   private int minIdle;
    +
    +   /**
    +    * The list of node is mandatory, and when nodes is not set, it throws 
NullPointerException.
    --- End diff --
    
    The constructor is private. So user has to set everything through builder 
class except nodes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to