[GitHub] [flink] godfreyhe commented on a change in pull request #17118: [FLINK-22603][table-planner]The digest can be produced by SourceAbilitySpec.

[GitBox]

godfreyhe commented on a change in pull request #17118:
URL: https://github.com/apache/flink/pull/17118#discussion_r704944200



##########
File path: 
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/schema/TableSourceTable.scala
##########
@@ -44,8 +43,8 @@ import org.apache.flink.table.types.logical.RowType
  * @param tableSource The [[DynamicTableSource]] for which is converted to a 
Calcite Table
  * @param isStreamingMode A flag that tells if the current table is in stream 
mode
  * @param catalogTable Resolved catalog table where this table source table 
comes from
- * @param flinkContext The flink context
- * @param abilitySpecs The abilitySpec applied to the source
+ * @param flinkContext The flink context abilitySpecs use to generate 
corresponding digests

Review comment:
       @param flinkContext which is used to generate extra digests based on 
abilitySpecs ?

##########
File path: 
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/TemporalTableSourceSpecSerdeTest.java
##########
@@ -59,17 +60,23 @@
 public class TemporalTableSourceSpecSerdeTest {
     private static final FlinkTypeFactory FACTORY = 
FlinkTypeFactory.INSTANCE();
 
+    private static final FlinkContext flinkContext = createFlinkContext();
+
+    private static FlinkContext createFlinkContext() {
+        return new FlinkContextImpl(
+                false,
+                TableConfig.getDefault(),
+                null,
+                CatalogManagerMocks.createEmptyCatalogManager(),
+                null);
+    }

Review comment:
       rivate static final FlinkContext FLINK_CONTEXT = new FlinkContextImpl(
                   false,
                   TableConfig.getDefault(),
                   null,
                   CatalogManagerMocks.createEmptyCatalogManager(),
                   null);

##########
File path: 
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/metadata/MetadataTestUtil.scala
##########
@@ -247,6 +248,18 @@ object MetadataTestUtil {
     getMetadataTable(fieldNames, fieldTypes, new FlinkStatistic(tableStats))
   }
 
+
+  private val flinkContext = createFlinkContext
+
+  private def createFlinkContext(): FlinkContext = {
+    new FlinkContextImpl(
+      false,
+      TableConfig.getDefault,
+      null,
+      CatalogManagerMocks.createEmptyCatalogManager,
+      null)
+  }

Review comment:
       private val flinkContext = new FlinkContextImpl(
         false,
         TableConfig.getDefault,
         null,
         CatalogManagerMocks.createEmptyCatalogManager,
         null)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org