gaoyunhaii commented on a change in pull request #17200:
URL: https://github.com/apache/flink/pull/17200#discussion_r705013784
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -529,6 +530,13 @@ protected void
processInput(MailboxDefaultAction.Controller controller) throws E
}
protected void endData() throws Exception {
+
+ if (syncSavepointWithoutDrain != null) {
Review comment:
Perhaps we only do the check if checkpoints after tasks finished are
enabled~? If not, the task would not wait for the final checkpoint and would
not be blocked, thus we might not change the behavior if flip-147 is not
enabled~
And also for the check in `performCheckpoint`~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
