zentol commented on a change in pull request #16978:
URL: https://github.com/apache/flink/pull/16978#discussion_r705127862
##########
File path: flink-test-utils-parent/flink-test-utils/pom.xml
##########
@@ -115,6 +115,14 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-statebackend-changelog</artifactId>
+ <version>${project.version}</version>
+ <!-- the dependency should be transitive -->
+ <scope>runtime</scope>
Review comment:
I would go with `runtime` because we want neither flink-test-utils nor
other modules to reference classes from the changelog backend in production
code (which `runtime` prevents).
We really just want to put it on the test classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
