dannycranmer commented on a change in pull request #17189:
URL: https://github.com/apache/flink/pull/17189#discussion_r705274129
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
##########
@@ -819,7 +819,7 @@ public void shutdownFetcher() {
LOG.warn("Encountered exception closing record publisher
factory", e);
}
} finally {
- shardConsumersExecutor.shutdownNow();
+ shardConsumersExecutor.shutdown();
Review comment:
There are no integration tests for EFO since Kinesalite does not support
EFO. Coincidentally I was recently discussing adding e2e test for EFO using AWS
creds. We need to work out how to supply AWS creds to make this happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
