[GitHub] [flink] matriv commented on a change in pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()

[GitBox]

matriv commented on a change in pull request #17217:
URL: https://github.com/apache/flink/pull/17217#discussion_r705283784



##########
File path: 
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java
##########
@@ -120,13 +121,16 @@ public StreamExecSink(
                 rowtimeFieldIndices.add(i);
             }
         }
+
+        final boolean isCollectSink = tableSinkSpec.getTableSink() instanceof 
CollectDynamicSink;

Review comment:
       Wouldn't it be "cleaner" if an `isCollectSink()` method (or 
simply`isCollect()`) is introduced to the iface?
   Or alternatively, if the method is implemented in a utility class in that 
package, so that changing the class to `public` just for the purpose of 
`instanceof` call is avoided? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org