Airblader commented on a change in pull request #17133: URL: https://github.com/apache/flink/pull/17133#discussion_r705958075
########## File path: flink-architecture-tests/src/test/resources/archunit.properties ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Path under which known violations will be stored for frozen rules +freeze.store.default.path=violations + +# Enable this to update the violations files Review comment: Since there are separate settings for creating and updating violation stores, my preferred approach at the moment would be to automatically update stores locally, but not create them. On CI both are disabled. I think this reduces developer frustration a bit since resolving a violation would automatically be recorded and not require changing some config and running the test again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
