twalthr commented on a change in pull request #17051:
URL: https://github.com/apache/flink/pull/17051#discussion_r706009518



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
##########
@@ -38,6 +43,12 @@
 @Internal
 public class FieldAccessorFactory implements Serializable {

Review comment:
       Have you thought about splitting this class into a new method in 
`TypeInformation`? This way we would not need to perform class lookup but can 
simply let the corresponding TypeInformation in Scala code decide. In any case, 
such a method can be marked immediatly as deprecated because we want to get rid 
of these field accessors anyway.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to