HuangXingBo commented on a change in pull request #17216:
URL: https://github.com/apache/flink/pull/17216#discussion_r706960738
##########
File path: flink-python/pyflink/pyflink_gateway_server.py
##########
@@ -30,27 +30,41 @@
from pyflink.find_flink_home import _find_flink_home, _find_flink_source_root
+KEY_ENV_LOG_DIR = "env.log.dir"
+KEY_ENV_YARN_CONF_DIR = "env.yarn.conf.dir"
+KEY_ENV_HADOOP_CONF_DIR = "env.hadoop.conf.dir"
+KEY_ENV_HBASE_CONF_DIR = "env.hbase.conf.dir"
+KEY_ENV_JAVA_HOME = "env.java.home"
+KEY_ENV_JAVA_OPTS = "env.java.opts"
+
def on_windows():
return platform.system() == "Windows"
-def find_java_executable():
- java_executable = "java.exe" if on_windows() else "java"
- flink_home = _find_flink_home()
- flink_conf_path = os.path.join(flink_home, "conf", "flink-conf.yaml")
- java_home = None
-
+def read_from_config(key, default_value, flink_conf_file):
+ value = default_value
Review comment:
```suggestion
def read_from_config(key, value, flink_conf_file):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
