[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344132#comment-15344132
]
ASF GitHub Bot commented on FLINK-4074:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68035356
--- Diff:
flink-metric-reporters/flink-metrics-statsd/src/main/java/org/apache/flink/metrics/statsd/StatsDReporter.java
---
@@ -53,6 +53,8 @@
// public static final String ARG_CONVERSION_RATE = "rateConversion";
// public static final String ARG_CONVERSION_DURATION =
"durationConversion";
+ private boolean cancel = false;
--- End diff --
Maybe we could rename the variable to `closed` or `running`.
> Reporter can block TaskManager shutdown
> ---------------------------------------
>
> Key: FLINK-4074
> URL: https://issues.apache.org/jira/browse/FLINK-4074
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.1.0
>
>
> If a report is being submitted while a TaskManager is shutting down the
> reporter can cause the shutdown to be delayed since it submits the complete
> report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
