twalthr commented on a change in pull request #17204:
URL: https://github.com/apache/flink/pull/17204#discussion_r707106716
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/PlannerMocks.java
##########
@@ -69,8 +85,37 @@ public static FlinkPlannerImpl createDefaultPlanner() {
functionCatalog.asLookup(parser::parseIdentifier),
catalogManager.getDataTypeFactory(),
parser::parseSqlExpression));
+ }
+
+ public FlinkPlannerImpl getPlanner() {
return planner;
}
- private PlannerMocks() {}
+ public ParserImpl getParser() {
+ return parser;
+ }
+
+ public CatalogManager getCatalogManager() {
+ return catalogManager;
+ }
+
+ public PlannerMocks registerTemporaryTable(String tableName, Schema
tableSchema) {
+ final CatalogTable table =
+ CatalogTable.of(tableSchema, null, Collections.emptyList(),
Collections.emptyMap());
+
+ this.getCatalogManager()
Review comment:
very nit: maybe this is personal taste but for future PRs, we can omit
`this` if it is not necessary, makes the code a bit more readable. in this case
I would even reference the field directly instead of the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
