Airblader commented on a change in pull request #17275:
URL: https://github.com/apache/flink/pull/17275#discussion_r707979158



##########
File path: docs/data/sql_functions.yml
##########
@@ -665,6 +665,9 @@ json:
       // STRING: "false"
       JSON_VALUE('{"a": true}', 'strict $.b'
           DEFAULT FALSE ON ERROR)
+
+      // DOUBLE: 0.998
+      JSON_VALUE('{"a": {"b.c": [0.998,0.996]}}','$.a.[''b.c''][0]' RETURNING 
DOUBLE)

Review comment:
       Since FLINK-24271 is about adding an example on how to access keys with 
"non-trivial" names, how about keeping the example as simple as possible to 
focus on actually showing how to do that? For example, like this:
   
   ```
   // STRING: '1'
   JSON_VALUE('{"a.b": "1"}', '$.[''a.b'']')
   ```
   
   Please also run the docs locally and make sure that the line length of the 
example doesn't cause the code block to scroll. If it does, line-break the 
example (as I did in the examples above) to prevent it from scrolling.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to