gaborgsomogyi commented on a change in pull request #16994:
URL: https://github.com/apache/flink/pull/16994#discussion_r708374188
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -741,6 +742,37 @@ public void
testDeployApplicationClusterWithDeploymentTargetNotCorrectlySet() {
}
}
+ @Test
+ public void testGetStagingDirWithoutSpecifyingStagingDir() throws
IOException {
+ try (final YarnClusterDescriptor yarnClusterDescriptor =
createYarnClusterDescriptor()) {
+ YarnConfiguration yarnConfig = new YarnConfiguration();
+ yarnConfig.set("fs.defaultFS", "file://tmp");
+ FileSystem defaultFileSystem = FileSystem.get(yarnConfig);
+ Path stagingDir =
yarnClusterDescriptor.getStagingDir(defaultFileSystem);
+ assertEquals(
Review comment:
We can be more specific in this case like down below:
```
assertEquals("file", defaultFileSystem.getScheme());
assertEquals("file",
stagingDir.getFileSystem(yarnConfig).getScheme());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
