Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2146
  
    Really good work @zentol. I had some minor comments concerning the 
instantiation of the `MetricRegistry` for the `JobManager` and some 
clarifications. I think it would be good if we could add some test cases which 
check, for example, that we report the correct checkpoint size and duration.
    
    Maybe you could also rebase this PR on the referred PR #2145. Then it would 
be easier to test the job manager metrics on a local machine. I would like to 
do it before merging. But once this is done, then I think we're good to merge 
your PR :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to