Airblader commented on a change in pull request #17204:
URL: https://github.com/apache/flink/pull/17204#discussion_r708912213
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkCalciteSqlValidator.java
##########
@@ -125,4 +126,17 @@ public void validateColumnListParams(
// this makes it possible to ignore them in the validator and fall
back to regular row types
// see also SqlFunction#deriveType
}
+
+ @Override
+ public void validateInsert(SqlInsert insert) {
+ // TODO Seems like this validation breaks the SqlToOperationConverter,
Review comment:
I think it would be better if we created an issue for it and then linked
to it. :-) I would open it as an improvement: it'd be a good thing to run the
validation, but of course we need to describe what's stopping us from it
(including one of the examples that break).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
