pnowojski commented on a change in pull request #17268:
URL: https://github.com/apache/flink/pull/17268#discussion_r709019305
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactory.java
##########
@@ -131,6 +131,9 @@ private NettyPartitionRequestClient
connectWithRetries(ConnectionID connectionId
private NettyPartitionRequestClient connect(ConnectionID connectionId)
throws RemoteTransportException, InterruptedException {
try {
+ // The highly important to use `sync` here because it waits for
this future until it is
+ // done, and rethrows the cause of the failure if this future
failed while `await` only
+ // waits for this future to be completed.(without rethrowing the
error).
Review comment:
```suggestion
// It's important to use `sync` here because it waits for this
future until it is
// done, and rethrows the cause of the failure if this future
failed. `await` only
// waits for this future to be completed, without throwing the
error.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
