godfreyhe commented on a change in pull request #16853:
URL: https://github.com/apache/flink/pull/16853#discussion_r709813156
##########
File path:
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/RankTest.xml
##########
@@ -1020,6 +1062,78 @@ Rank(strategy=[RetractStrategy], rankType=[ROW_NUMBER],
rankRange=[rankStart=1,
+- GroupAggregate(groupBy=[category, shopId], select=[category, shopId,
MAX(price) AS max_price], changelogMode=[I,UB,UA])
+- Exchange(distribution=[hash[category, shopId]], changelogMode=[I])
+- LegacyTableSourceScan(table=[[default_catalog, default_database,
T, source: [TestTableSource(category, shopId, price)]]], fields=[category,
shopId, price], changelogMode=[I])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testUpdatableRankAfterIntermediateScan">
+ <Resource name="ast">
+ <![CDATA[
+LogicalSink(table=[default_catalog.default_database.sink], fields=[a, b, c])
++- LogicalProject(a=[$0], b=[$1], c=[$2])
+ +- LogicalAggregate(group=[{0}], b=[MAX($1)], c=[MIN($2)])
+ +- LogicalProject(a=[$0], b=[$1], c=[$2])
+ +- LogicalTableScan(table=[[default_catalog, default_database,
MyTable]])
+
+LogicalSink(table=[default_catalog.default_database.sink], fields=[a, b, c])
++- LogicalProject(a=[$0], b=[$1], c=[$2])
+ +- LogicalFilter(condition=[<($3, 3)])
+ +- LogicalProject(a=[$0], b=[$1], c=[$2], rn=[ROW_NUMBER() OVER
(PARTITION BY $0 ORDER BY $1 DESC NULLS LAST)])
+ +- LogicalAggregate(group=[{0}], b=[MAX($1)], c=[MIN($2)])
+ +- LogicalProject(a=[$0], b=[$1], c=[$2])
+ +- LogicalTableScan(table=[[default_catalog, default_database,
MyTable]])
+]]>
+ </Resource>
+ <Resource name="optimized exec plan">
+ <![CDATA[
+GroupAggregate(groupBy=[a], select=[a, MAX(b) AS b, MIN(c) AS c])(reuse_id=[1])
++- Exchange(distribution=[hash[a]])
+ +- Calc(select=[a, b, c])
+ +- DataStreamScan(table=[[default_catalog, default_database, MyTable]],
fields=[a, b, c, proctime, rowtime])
+
+Sink(table=[default_catalog.default_database.sink], fields=[a, b, c])
++- Reused(reference_id=[1])
+
+Sink(table=[default_catalog.default_database.sink], fields=[a, b, c])
++- Rank(strategy=[UpdateFastStrategy[0]], rankType=[ROW_NUMBER],
rankRange=[rankStart=1, rankEnd=2], partitionBy=[a], orderBy=[b DESC],
select=[a, b, c])
+ +- Exchange(distribution=[hash[a]])
+ +- Reused(reference_id=[1])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testUpdatabletRankWithDeduplicate">
Review comment:
nit: typo: Updatablet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
