pnowojski commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r709949196
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java
##########
@@ -67,6 +75,7 @@ public static void subsume(
}
// Don't break out from the loop to subsume intermediate savepoints
}
+ return lastSubsumedCheckpoint;
Review comment:
edit: actually after removing field `@Nullable private
CompletedCheckpoint lastSubsumedCheckpoint;` I don't see actually much
difference between those two approaches. Is there a problem that I'm missing?
Note it doesn't help that the changes are not squashed, ant that the counter
proposal is also a separate commit on top of this PR. It makes reviewing and
comparing both options very difficult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
