akalash commented on a change in pull request #17238:
URL: https://github.com/apache/flink/pull/17238#discussion_r709980406
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -240,7 +240,9 @@ public Throwable getFailureCause() {
@Override
public void releaseAllResources() throws IOException {
- subpartitionView.releaseAllResources();
+ if (subpartitionView != null) {
+ subpartitionView.releaseAllResources();
+ }
Review comment:
Before FLINK-9057, we called notifyReaderCreated before
requestSubpartitionView but it leaded to NPE in releaseAllResources so during
the fixing FLINK-9057 the order was changed and notifyReaderCreated started to
call after requestSubpartitionView which fixed the problem with NPE. Right now,
I returned the original order(notifyReaderCreated is before
requestSubpartitionView) so because of it, I should somehow fix the NPE.
But I agree that perhaps, it doesn't make sense to use FLINK-9057 in the
commit. Maybe I should fix the NPE under the current ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
