Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2108#discussion_r68082639
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
 ---
    @@ -50,11 +53,13 @@
     /**
      * Flink Sink to produce data into a Kafka topic.
      *
    - * Please note that this producer does not have any reliability guarantees.
    + * Please note that this producer provides at-least-once reliability 
guarantees when
    + * checkpoints are enabled and setFlushOnCheckpoint(true) is set.
    + * Otherwise, the producer doesn't provide any reliability guarantees.
    --- End diff --
    
    My reasoning here was that we first provide this as an optional feature to 
those users who know what they are doing / what they need to give the feature 
exposure.
    I want to be certain that it works in all environments before we activate 
it by default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to