Myasuka commented on a change in pull request #17203:
URL: https://github.com/apache/flink/pull/17203#discussion_r710671588
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/restore/ChangelogBackendRestoreOperation.java
##########
@@ -89,14 +82,11 @@
ChangelogKeyedStateBackend<?> backend,
ChangelogStateBackendHandle backendHandle,
StateChangelogHandleReader<T> changelogHandleReader,
- ClassLoader classLoader,
- Map<UUID, Map<Short, StateID>> metadataByBackend)
+ ClassLoader classLoader)
throws Exception {
+ Map<Short, StateID> stateIds = new HashMap<>();
Review comment:
The equivalent change should be creating the stateIds within the for
loop, otherwise, the stateIds would contain short state id created by other
state backends. Though we would update the state id during meta restore, I'm
afraid that this might not be safe if we change implementation of updating the
meta in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
