SteNicholas commented on a change in pull request #17245: URL: https://github.com/apache/flink/pull/17245#discussion_r710971933
########## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/CustomCommitPolicy.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connectors.hive; + +import org.apache.flink.table.filesystem.PartitionCommitPolicy; + +import java.util.HashSet; +import java.util.Set; + +/** A custom PartitionCommitPolicy for test. */ +public class CustomCommitPolicy implements PartitionCommitPolicy { Review comment: ```suggestion public class TestCustomCommitPolicy implements PartitionCommitPolicy { ``` ########## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java ########## @@ -153,15 +161,15 @@ public void testBatchAppend() throws Exception { @Test public void testDefaultSerPartStreamingWrite() throws Exception { - testStreamingWrite(true, false, "textfile", this::checkSuccessFiles); + testStreamingWrite(true, false, "textfile", this::checkPartitionCommitSuccessfully); Review comment: IMO, the original check for success files doesn' need to modify. You could add the new tests for the custom `PartitionCommitPolicy`. ########## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/CustomCommitPolicy.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connectors.hive; + +import org.apache.flink.table.filesystem.PartitionCommitPolicy; + +import java.util.HashSet; +import java.util.Set; + +/** A custom PartitionCommitPolicy for test. */ +public class CustomCommitPolicy implements PartitionCommitPolicy { + + private static Set<String> committedPartitionPaths = new HashSet<>(); Review comment: Why is the `committedPartitionPaths` regarded as static? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
