ljdavns opened a new pull request #17325:
URL: https://github.com/apache/flink/pull/17325


   ## What is the purpose of the change
   
   Make the building process of module _**flink-runtime-web**_ doesn't throw 
error on Windows.
   Git will transform all the source code's line seperator to CRLF(for 
developers working on windows) include the js and ts files in _flink 
webdashboard_, and that makes eslint throw errors like Delete \`␍\` 
eslint(prettier/prettier).
   
   But if I set git autocrlf to false, the spotless-check will throw error 
because of the line seperator of java source file is not CRLF.
   
   ## Brief change log
   
   After changing the .eslintrc.js file(add an endOfLine setting), the building 
process succeed.
   
   ```
   'prettier/prettier': [
     'error',
     {
       parser: 'angular',
       endOfLine: 'auto'
     }
   ```
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   use `mvn clean package` command to build module _**flink-runtime-web**_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to