[
https://issues.apache.org/jira/browse/FLINK-24344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Nowojski updated FLINK-24344:
-----------------------------------
Description:
When running
{{CheckpointCoordinatorTest#testTriggerCheckpointAfterIOException}}, it
simulates an {{IOException}} thrown from
{{CheckpointCoordinator#initializeCheckpoint}}. Which makes sense but:
# This exception never reaches {{CheckpointFailureManager}} because of the
logic in {{CheckpointCoordinator#onTriggerFailure()}}. So the main purpose of
the FLINK-23189 ticket is not working as intended.
# it would be however much much better to throw {{IOException}} from
{{checkpointStorageView.initializeLocationForCheckpoint}} rather from
{{checkpointIdCounter.getAndIncrement}}. The latter could be refactored out,
while the production {{IOException}} can be thrown in reality from
{{initializeLocationForCheckpoint}})
> Handling of IOExceptions when triggering checkpoints doesn't cause job
> failover
> -------------------------------------------------------------------------------
>
> Key: FLINK-24344
> URL: https://issues.apache.org/jira/browse/FLINK-24344
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
> Affects Versions: 1.14.0
> Reporter: Piotr Nowojski
> Priority: Critical
> Fix For: 1.14.0, 1.15.0
>
>
> When running
> {{CheckpointCoordinatorTest#testTriggerCheckpointAfterIOException}}, it
> simulates an {{IOException}} thrown from
> {{CheckpointCoordinator#initializeCheckpoint}}. Which makes sense but:
> # This exception never reaches {{CheckpointFailureManager}} because of the
> logic in {{CheckpointCoordinator#onTriggerFailure()}}. So the main purpose of
> the FLINK-23189 ticket is not working as intended.
> # it would be however much much better to throw {{IOException}} from
> {{checkpointStorageView.initializeLocationForCheckpoint}} rather from
> {{checkpointIdCounter.getAndIncrement}}. The latter could be refactored out,
> while the production {{IOException}} can be thrown in reality from
> {{initializeLocationForCheckpoint}})
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
