dawidwys commented on a change in pull request #17278:
URL: https://github.com/apache/flink/pull/17278#discussion_r713024837



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -323,10 +323,6 @@ public CheckpointCoordinator(
 
         try {
             this.checkpointStorageView = 
checkpointStorage.createCheckpointStorage(job);
-
-            if (isPeriodicCheckpointingConfigured()) {
-                checkpointStorageView.initializeBaseLocationsForCheckpoint();
-            }

Review comment:
       No, it would not be complicated. It would be very straightforward to do.
   
   In general the change that introduced `initializeBaseLocationsForCheckpoint` 
was not about falling early, but so that we call the filesystem just once, 
which still holds. But I agree the current code might introduce some delay to 
the first checkpointing compared to master.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to