Airblader commented on a change in pull request #17332:
URL: https://github.com/apache/flink/pull/17332#discussion_r713637141
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java
##########
@@ -142,4 +143,16 @@
*/
String getSelectFromStatement(
String tableName, String[] selectFields, String[] conditionFields);
+
+ /** Create catalog instance. */
+ default AbstractJdbcCatalog createCatalog(
+ String catalogName,
Review comment:
Yeah, I think passing the original `CatalogFactory#Context` would be
best as that gives implementations access to everything a normal catalog
factory would have access to, like the configuration and classloader. We should
also annotate `JdbcCatalogFactoryOptions` as `@PublicEvolving` then so
implementations can use it to retrieve catalog options.
I'm now seeing that `JdbcCatalog` is already public and hard-wired to use
username/password. That is unfortunate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
