pnowojski commented on a change in pull request #17331:
URL: https://github.com/apache/flink/pull/17331#discussion_r713855871
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1955,6 +1959,25 @@ private void abortPendingCheckpoint(
}
}
+ private void handleCheckpointException(
+ PendingCheckpoint pendingCheckpoint,
+ CheckpointProperties checkpointProperties,
+ CheckpointException exception,
+ ExecutionAttemptID executionAttemptID) {
+ if (checkpointProperties.isSavepoint()
+ && (checkpointProperties.isSynchronous() || pendingCheckpoint
== null)) {
+ failureManager.handleSynchronousSavepointFailure(exception);
Review comment:
async phase of checkpoint has unfortunately nothing to do with
"synchronous savepoint". Synchronous savepoint is a bad internal name for a
savepoint barrier that is part of "stop-with-savepoint" feature. In this
context, non-synchronous savepoint are savepoints that are not followed by
stopping of the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
