is commented on a change in pull request #17322:
URL: https://github.com/apache/flink/pull/17322#discussion_r714527160
##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -1695,12 +1695,14 @@ def _add_jars_to_j_env_config(self, config_key):
jar_urls =
self.get_config().get_configuration().get_string(config_key, None)
if jar_urls is not None:
# normalize and remove duplicates
- jar_urls_set = set([jvm.java.net.URL(url).toString() for url in
jar_urls.split(";")])
+ # do not use set, because set does not guarantee order.
+ jar_urls_list = [jvm.java.net.URL(url).toString() for url in
jar_urls.split(";")]
Review comment:
In normal circumstances, keeping the order of classpaths is not
necessary.
When investigating some problem, the random order is disturbing,
we spent many times to find why the classpaths is changed randomly.
and list is efficient enough in this case. So I think keep order
is better choice. Keep things stable, make things simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
