slinkydeveloper commented on a change in pull request #17297:
URL: https://github.com/apache/flink/pull/17297#discussion_r714647214
##########
File path: docs/content.zh/docs/dev/table/data_stream_api.md
##########
@@ -788,8 +788,8 @@ val table =
Schema.newBuilder()
.column("uid", DataTypes.TINYINT())
.column("payload", DataTypes.STRING())
- .build())
- .build());
+ .build())
Review comment:
`.build()` should be aligned with the rest of the builder methods
invocation
##########
File path: docs/content.zh/docs/dev/datastream/user_defined_functions.md
##########
@@ -136,8 +140,8 @@ data.map { x => x.toInt }
```scala
class MyMapFunction extends RichMapFunction[String, Int] {
- def map(in: String):Int = { in.toInt }
-};
+ def map(in: String): Int = { in.toInt }
Review comment:
Same comment as above
##########
File path: docs/content.zh/docs/dev/table/data_stream_api.md
##########
@@ -788,8 +788,8 @@ val table =
Schema.newBuilder()
.column("uid", DataTypes.TINYINT())
.column("payload", DataTypes.STRING())
- .build())
- .build());
+ .build())
+ .build())
Review comment:
Same
##########
File path: docs/content/docs/dev/table/data_stream_api.md
##########
@@ -788,8 +788,8 @@ val table =
Schema.newBuilder()
.column("uid", DataTypes.TINYINT())
.column("payload", DataTypes.STRING())
- .build())
- .build());
+ .build())
+ .build())
Review comment:
Same as above
##########
File path: docs/content.zh/docs/dev/datastream/operators/joining.md
##########
@@ -278,10 +278,10 @@ orangeStream
.between(Time.milliseconds(-2), Time.milliseconds(1))
.process(new ProcessJoinFunction[Integer, Integer, String] {
override def processElement(left: Integer, right: Integer, ctx:
ProcessJoinFunction[Integer, Integer, String]#Context, out: Collector[String]):
Unit = {
Review comment:
Perhaps here you can even remove the enclosing { } for the body method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
