[
https://issues.apache.org/jira/browse/FLINK-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346545#comment-15346545
]
ASF GitHub Bot commented on FLINK-4093:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2134#discussion_r68248549
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -146,7 +147,16 @@ public Counter counter(int name) {
@Override
public Counter counter(String name) {
- Counter counter = new Counter();
+ return counter(name, new SimpleCounter());
+ }
+
+ @Override
+ public <C extends Counter> C counter(int name, C counter) {
--- End diff --
What's the advantage of introducing the bounded generic parameter over
simply having a `Counter` parameter?
> Expose metric interfaces
> ------------------------
>
> Key: FLINK-4093
> URL: https://issues.apache.org/jira/browse/FLINK-4093
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
