fapaul commented on a change in pull request #17351:
URL: https://github.com/apache/flink/pull/17351#discussion_r716397622
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/NoopCommitterHandler.java
##########
@@ -34,7 +34,8 @@
@Override
public List<Object> processCommittables(
- SupplierWithException<List<Object>, Exception>
committableSupplier) {
+ SupplierWithException<List<Object>, Exception>
committableSupplier) throws Exception {
+ committableSupplier.get();
Review comment:
> Why is this needed, what's not working in this way? It feels
counter-intuitive to have `preCommit` without `commit`. It seems like I missed
a case when I explicitly structured the code to not call `preCommit`.
AFAICT all async sinks which want to implement at-least-once cannot work
currently. They are all built on the assumption that during `preCommit`
`mailbox.yield()` is called until all outstanding message callbacks are called
but they do not have any transaction-like to commit (no committer). I
personally experienced the issue when trying to implement the elasticseach sink.
> If we always want to `preCommit`, then please refactor such that
`preCommit` is called on call-site (e.g. remove the `Supplier` and directly
pass the result.
Sure can do that 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
