curcur commented on a change in pull request #16606:
URL: https://github.com/apache/flink/pull/16606#discussion_r717212224
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/Environment.java
##########
@@ -258,4 +259,10 @@ default void setAsyncOperationsThreadPool(ExecutorService
executorService) {}
default ExecutorService getAsyncOperationsThreadPool() {
throw new UnsupportedOperationException();
}
+
+ default void setCheckpointStorageAccess(CheckpointStorageAccess
checkpointStorageAccess) {}
+
+ default CheckpointStorageAccess getCheckpointStorageAccess() {
+ throw new UnsupportedOperationException();
+ }
Review comment:
> Thanks updating the PR @curcur.
>
> I've left some comments, PTAL.
>
> Besides that, could you please name the extracted commits according to
[conventions](https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#commit-naming-conventions)
(add `[hotfix]` and component label, fix case, etc.).
which of the commits do you think not following the convention?
If you mean the [hotfix] one, It is to fix a file naming issue for log4j2
file. I am not sure whether it is belonging to a "component"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
