[
https://issues.apache.org/jira/browse/FLINK-24399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421410#comment-17421410
]
Francesco Guardiani commented on FLINK-24399:
---------------------------------------------
Should we perhaps consider in the context of this issue to annotate some
methods in {{DataTypeUtils}} {{@PublicEvolving}} more than {{@Internal}}? So we
can keep the {{DataType}} interface slim, and at the same time we provide all
the connector developers need. E.g. I would avoid
{{DataType#getProjectedFields}} because it's very specific and seems to me the
sort of method that should live in a utils class, while IMO we should have
{{DataType#getFieldNames}} more than asking users to use
{{DataTypeUtils#flattenToNames}}.
> Make handling of DataType less verbose
> --------------------------------------
>
> Key: FLINK-24399
> URL: https://issues.apache.org/jira/browse/FLINK-24399
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / API
> Reporter: Timo Walther
> Priority: Major
>
> {{DataType}} is the API abstraction for declaring types and always includes
> the {{LogicalType}} as well. In order to ease the handling of this class, we
> should do the following additions:
> - {{DynamicTableFactory.Context#getPhysicalRowDataType(): DataType}}
> - {{DynamicTableFactory.Context#getPrimaryKeyFields(): int[]}}
> - {{DataType#getFieldNames: List<String>}} (empty for atomics)
> - {{DataType#getFieldDataTypes: List<DataType>}} as a synonym for
> {{getChildren}} (empty for atomics)
> - {{DataType#getFieldCount: int}} (0 for atomics)
> - {{DataType#getProjectedFields(int[][]): DataType}} (like
> {{DataTypeUtils#projectRow}})
> - {{DataType#getProjectedFields(int[]): DataType}} (like
> {{DataTypeUtils#projectRow}})
> This should simplify implementations and avoid needs for internal utilities.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
