Airblader commented on a change in pull request #17384:
URL: https://github.com/apache/flink/pull/17384#discussion_r718453917
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -125,12 +125,14 @@
public static final String PLACEHOLDER_SYMBOL = "#";
/**
- * Creates a {@link DynamicTableSource} from a {@link CatalogTable}.
+ * Creates a {@link DynamicTableSource}.
*
- * <p>It considers {@link Catalog#getFactory()} if provided.
+ * <p>If {@param preferredFactory} is passed, the table source is created
from that factory.
+ * Otherwise, an attempt is made to discover a matching factory using Java
SPI (see {@link
+ * Factory} for details).
*/
- public static DynamicTableSource createTableSource(
- @Nullable Catalog catalog,
+ public static DynamicTableSource createSource(
Review comment:
I shortened the name here because simply adding an overload (replacing
the first argument) would be a breaking change when `null` is passed (as it
would cause an ambiguity).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
