slinkydeveloper commented on a change in pull request #17381:
URL: https://github.com/apache/flink/pull/17381#discussion_r718426788
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/DataTypeUtils.java
##########
@@ -334,12 +334,15 @@ public static ResolvedSchema
expandCompositeTypeToSchema(DataType dataType) {
return Collections.singletonList(dataType);
}
- /** Returns the names of the flat representation in the first level of the
given data type. */
+ /**
+ * Returns the names of the flat representation of the given data type. In
case of {@link
+ * StructuredType}, returns the deep list of field names of the structure.
Review comment:
This particular method goes deep into a structured type:
https://github.com/apache/flink/blob/276e847efbfe39a567a8033dd52ff9245aee9de1/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java#L483
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/DynamicTableFactory.java
##########
@@ -85,5 +88,23 @@
/** Whether the table is temporary. */
boolean isTemporary();
+
+ /**
+ * Shortcut for {@code
getCatalogTable().getResolvedSchema().toPhysicalRowDataType()}.
+ *
+ * @see ResolvedSchema#toPhysicalRowDataType()
+ */
+ default FieldsDataType getPhysicalRowDataType() {
+ return
getCatalogTable().getResolvedSchema().toPhysicalRowDataType();
+ }
+
+ /**
+ * Shortcut for {@code
getCatalogTable().getResolvedSchema().getPrimaryKeyFields()}.
+ *
+ * @see ResolvedSchema#getPrimaryKeyFields()
+ */
+ default List<String> getPrimaryKeyFields() {
Review comment:
Gotcha, what about naming it `getPrimaryKeyIndexes` or
`getPrimaryKeyFieldsIndexes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
