curcur commented on a change in pull request #17354:
URL: https://github.com/apache/flink/pull/17354#discussion_r719048866
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierTrackerTest.java
##########
@@ -607,13 +606,26 @@ public void testTwoLastBarriersOneByOne() throws
Exception {
ValidatingCheckpointHandler validator = new
ValidatingCheckpointHandler();
inputGate = createCheckpointedInputGate(2, sequence, validator);
- for (BufferOrEvent boe : sequence) {
- assertEquals(boe, inputGate.pollNext().get());
- Thread.sleep(10);
- }
+ // start checkpoint 1
+ assertEquals(sequence[0], inputGate.pollNext().get());
+ Thread.sleep(10);
+
+ // start checkpoint 2
+ long start = System.currentTimeMillis();
+ assertEquals(sequence[1], inputGate.pollNext().get());
+ Thread.sleep(1);
Review comment:
nit: maybe keep it as sleep(10)?
Do you know whether the alignment timer works the same as the system timer?
If not, the test may still be unstable until we introduce the manual clock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
