matriv commented on pull request #17396: URL: https://github.com/apache/flink/pull/17396#issuecomment-931372324
> * I see there are some failing "casts" returning null. Perhaps, given the [TRY_CAST issue](https://issues.apache.org/jira/browse/FLINK-24385), would it be better for the `CastTestSpecBuilder` to have a method like `fails` or something like that? Now such a method should just wrap the `resultsIn(null)` invocation, but when the TRY_CAST issue is tackled it can be modified to assert if an exception is thrown when executing the query. So we can just reuse these test cases for TRY_CAST as well Good idea, I'll try to "prepare the ground" for the upcoming changes and tests, thx! > * Related to errors with casting, what happens when casting to NON NULL types, eg what happens when invoking `CAST(f0 AS STRING NON NULL)`? Adding nullability combinations here would explode the number of tests, the nullability itself is unit tested in `LogicalTypeCastsTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
