JingGe opened a new pull request #17413:
URL: https://github.com/apache/flink/pull/17413
## What is the purpose of the change
This pull request removes the duplicated code for arguments check.
## Brief change log
- Consolidate the arguments check in the forBulkFileFormat(...) method
that will be called by other method for different Format i.e.
forRecordStreamFormat(...) and forRecordFileFormat(...). Duplicated code is
therefore removed.
- Rename method argument names from "reader" to ***Format to improve the
code readability.
## Verifying this change
This change is already covered by existing tests, such as
*FileSourceTextLinesITCase* and *FileSourceHeavyThroughputTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
