matriv opened a new pull request #17418: URL: https://github.com/apache/flink/pull/17418
## What is the purpose of the change Following calcite-avatica behaviour, fix the behaviour of parsing string into unix time when the string is incomplete, missing 1 or both `:` time units separator. Previously, minutes and seconds where set to default value `1` instead of `0` when missing from the parsed string. Issue was fixed in avatica with: https://github.com/apache/calcite-avatica/commit/cac2ffaaf97572d21cba195d7590d9ab0d32382e ## Brief change log - Apply the fix for parsing strings into time as in calcite-avatica ## Verifying this change This change added tests and can be verified as follows: - Changed tests for CASTing string to TIME() which uses the method in question - Added more tests to demonstrate better the behaviour for such edge cases ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
