pnowojski commented on a change in pull request #34:
URL: https://github.com/apache/flink-benchmarks/pull/34#discussion_r723331461



##########
File path: 
src/main/java/org/apache/flink/benchmark/CheckpointingTimeBenchmark.java
##########
@@ -285,7 +282,7 @@ protected int getNumberOfSlotsPerTaskManager() {
     public static class SlowDiscardSink<T> implements SinkFunction<T> {
         @Override
         public void invoke(T value, Context context) throws Exception {
-            Thread.sleep(1);
+            Thread.sleep(0, 500_000);

Review comment:
       This change shouldn't have any effect (take a look at the 
`Thead.sleep(millis, nanos)` implementation.
   
   Has this change really speed up anything?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to