zentol commented on a change in pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100#discussion_r724110204



##########
File path: 
flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
 This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
 - com.google.guava:guava:27.0.1-jre

Review comment:
       There are separate modules for the ZK versions. zookeeper-35 for 3.5, 
zookeeper34 for 3.4.

##########
File path: 
flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
 This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
 - com.google.guava:guava:27.0.1-jre

Review comment:
       There are separate modules for the ZK versions. zookeeper-35 for 3.5, 
zookeeper-34 for 3.4.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to