curcur commented on pull request #16606:
URL: https://github.com/apache/flink/pull/16606#issuecomment-939874452


   @rkhachatryan , I've removed the change ``waiting for termination of 
periodicExecutor''
   
   The periodicExecutor is the executor to trigger the scheduling, I am not 
sure awaits it helps to solve the problem of untracked files (untracked files 
are uploaded by a separate thread pool). And since most of the time of a task 
is used for waiting the `periodicMaterializeDelay`, It has a very high 
probability that each shut down has to wait till timeout.
   
   It does not bring too many benefits but make the shutdown of a flink job 
much slower than before. 
   
   So I removed the awaits.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to