CrynetLogistics commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r726172890
########## File path: flink-connectors/flink-connector-aws/src/main/java/org/apache/flink/streaming/connectors/kinesis/async/KinesisDataStreamsSinkConfig.java ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.connectors.kinesis.async; + +import org.apache.flink.connector.base.sink.writer.ElementConverter; +import org.apache.flink.util.Preconditions; + +import software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry; + +import java.io.Serializable; + +/** Configuration for {@link KinesisDataStreamsSink}. */ +public class KinesisDataStreamsSinkConfig<InputT> implements Serializable { + + private static final int DEFAULT_MAX_BATCH_SIZE = 100; + private static final int DEFAULT_MAX_IN_FLIGHT_REQUESTS = 8; + private static final int DEFAULT_MAX_BUFFERED_REQUESTS = 1000; + private static final long DEFAULT_FLUSH_ON_BUFFER_SIZE_IN_B = 64 * 1024 * 1024; + private static final long DEFAULT_MAX_TIME_IN_BUFFER_MS = 1000; + + private final ElementConverter<InputT, PutRecordsRequestEntry> elementConverter; + private final int maxBatchSize; + private final int maxInFlightRequests; + private final int maxBufferedRequests; + private final long flushOnBufferSizeInBytes; + private final long maxTimeInBufferMS; Review comment: I think this is a good idea. Let me do that refactor now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
