[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350919#comment-15350919
]
ASF GitHub Bot commented on FLINK-4084:
---------------------------------------
Github user alkagin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r68568030
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -132,9 +132,9 @@
- private final Configuration config;
+ private Configuration config;
--- End diff --
I removed final from clientTimeout and config because I need to reassign
them in
[CliFrontend.java#L219](https://github.com/alkagin/flink/blob/bb9203923edeb02258455712db579d09dd3e7e62/flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java#L219),
as far as I understand `--configDir` option must be available just in `run`
mode. Is it correct? Otherwise I can read it in the main and instantiate
correctly CliFrontend passing the configDir.
> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
> Key: FLINK-4084
> URL: https://issues.apache.org/jira/browse/FLINK-4084
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Andrea Sella
> Priority: Minor
>
> At the moment there is no other way than the environment variable
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if
> it is started via the flink shell script. In order to improve the user
> exprience, I would propose to introduce a {{--configDir}} parameter which the
> user can use to specify a configuration directory more easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
