slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r727078879
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java
##########
@@ -21,19 +21,39 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.core.execution.JobClient;
import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.data.RowData;
import org.apache.flink.types.Row;
import org.apache.flink.util.CloseableIterator;
/**
* An internal class which helps the client to get the execute result from a
specific sink.
*
+ * <p>The two iterators are exclusive, that is you can use only one of the two
at the same time.
+ *
* <p>This class is generated by specific sink and brings the result info to a
{@link TableResult}.
*/
@Internal
-public interface CollectResultProvider {
+public interface ResultProvider {
/** Set the job client associated with the select job to retrieve the
result. */
- void setJobClient(JobClient jobClient);
+ ResultProvider setJobClient(JobClient jobClient);
Review comment:
for fluency, which is useful in some call sites, i can remove it
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java
##########
@@ -21,19 +21,39 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.core.execution.JobClient;
import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.data.RowData;
import org.apache.flink.types.Row;
import org.apache.flink.util.CloseableIterator;
/**
* An internal class which helps the client to get the execute result from a
specific sink.
*
+ * <p>The two iterators are exclusive, that is you can use only one of the two
at the same time.
+ *
* <p>This class is generated by specific sink and brings the result info to a
{@link TableResult}.
*/
@Internal
-public interface CollectResultProvider {
+public interface ResultProvider {
/** Set the job client associated with the select job to retrieve the
result. */
- void setJobClient(JobClient jobClient);
+ ResultProvider setJobClient(JobClient jobClient);
Review comment:
for fluency, which is useful in some call sites, i can remove it if you
want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
