Myasuka commented on a change in pull request #17419:
URL: https://github.com/apache/flink/pull/17419#discussion_r727686247
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksIteratorWrapper.java
##########
@@ -111,7 +114,6 @@ public void status() {
@Override
public void refresh() throws RocksDBException {
iterator.refresh();
- status();
Review comment:
I think we'd better leave the `status()` check for `refresh()` API here.
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksIteratorWrapper.java
##########
@@ -111,7 +114,6 @@ public void status() {
@Override
public void refresh() throws RocksDBException {
iterator.refresh();
- status();
Review comment:
The original PR of RocksDB targets for `seek` with `next` operations, I
did not take a look at the code implementation of `refresh` yet, but I think
it's better to leave the check there. BTW, `refresh` API is not used by Flink
yet, we don't have experience of the risk to remove the check. For the purpose
of safety, I think we'd better leave the check of `status()` there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
